-
Notifications
You must be signed in to change notification settings - Fork 533
ENH: Add reverse-ordered transform lists to ants.Registration outputs #3192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… ANTS Registration outputs.
Any reason why the doctests are failing here. ? |
Codecov Report
@@ Coverage Diff @@
## master #3192 +/- ##
=======================================
Coverage 65.07% 65.08%
=======================================
Files 301 301
Lines 39624 39628 +4
Branches 5247 5247
=======================================
+ Hits 25786 25790 +4
Misses 12771 12771
Partials 1067 1067
Continue to review full report at Codecov.
|
Do you think we can incorporate this into pypi soon? |
Can you link to the documentation? It's difficult to review a pull request without context. |
Here is the documentation. nipype/nipype/interfaces/ants/registration.py Line 646 in c37fcfb
|
reverse_transform is actually a collection of inverse transformations. This corresponds to the reverse_invert_flags as well. |
Any way we can integrate this sooner to pypi? |
I also would appreciate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@effigies - seems reasonable from a conceptual standpoint and provides a handy helper to ease inverting lists. i think the docstring still says to use composite transforms when possible. |
… ANTS Registration outputs.
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment