Skip to content

MNT: Update Zenodo ordering based on commit count #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2020

Conversation

effigies
Copy link
Member

Summary

I said I'd do this before another minor release. With several major refactors and restylings, a lot of people who've put in significant effort to nipype had their contributions reduced by ranking by total lines last touched as opposed to commits.

Obviously neither is perfect, but lines-last-touched seems like it has gotten distinctly less valid since we ran black nipype.

I haven't tabulated up who has risen or fallen significantly. Not sure it really matters.

For the record, here is the new output:

No entry to sort: cdla
No entry to sort: Gio Piantoni
No entry to sort: Victor Férat
No entry to sort: Niklas Förster
No entry to sort: Adam Kimbler
No entry to sort: Kirstie Whitaker
No entry to sort: Pablo Polosecki
No entry to sort: Ami Tsuchida
No entry to sort: Daniel Brenner
No entry to sort: Isaiah Norton
No entry to sort: Kevin Sitek
No entry to sort: Martin Luessi
No entry to sort: steve
No entry to sort: Charl Linssen
No entry to sort: Félix C. Morency
No entry to sort: Jonathan R. Williford
No entry to sort: Luke Bloy
No entry to sort: Michiel Cottaar
No entry to sort: Regina Kim
No entry to sort: Valentin Haenel
No entry to sort: Xu Wang
No entry to sort: maedoc
No matching commits: Paul Glad Mihai

I have manually verified that all entries have been reordered, and nobody has been dropped. Two entries had been duplicated and are now present only once.

List of changes proposed in this PR (pull-request)

  • Switch to git shortlog -ns to get names and commit counts. This has a secondary advantage of being much quicker than git line-summary
  • Prints out unmatched names from both git shortlog and the preexisting creators list
  • Stable ordering: alphabetical by first name if commit counts match. This should end the meaningless reordering that has happend with every release.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies added this to the 1.5.0 milestone Feb 12, 2020
@satra
Copy link
Member

satra commented Feb 12, 2020

thank you @effigies - i also think we should just add a pointer to the parent zenodo URL for nipype in the about.rst file instead of the full citation, so that we don't have to redo it on every release. right now it points to 0.13.1. perhaps that change can be included in this PR?

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #3169 into master will increase coverage by 1.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3169      +/-   ##
==========================================
+ Coverage   64.00%   65.56%   +1.55%     
==========================================
  Files         299      299              
  Lines       39494    39494              
  Branches     5219     5219              
==========================================
+ Hits        25278    25894     +616     
+ Misses      13173    12724     -449     
+ Partials     1043      876     -167     
Flag Coverage Δ
#smoketests 45.41% <ø> (?)
#unittests 64.86% <ø> (+0.82%) ⬆️
Impacted Files Coverage Δ
nipype/testing/__init__.py 88.88% <0.00%> (ø) ⬆️
nipype/utils/profiler.py 18.49% <0.00%> (+0.57%) ⬆️
nipype/interfaces/spm/preprocess.py 52.78% <0.00%> (+0.65%) ⬆️
nipype/interfaces/dcm2nii.py 49.76% <0.00%> (+0.93%) ⬆️
nipype/interfaces/fsl/base.py 80.89% <0.00%> (+1.12%) ⬆️
nipype/interfaces/freesurfer/model.py 64.19% <0.00%> (+1.12%) ⬆️
nipype/interfaces/utility/base.py 87.20% <0.00%> (+1.16%) ⬆️
nipype/utils/misc.py 60.50% <0.00%> (+1.27%) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.04% <0.00%> (+1.57%) ⬆️
nipype/pipeline/engine/base.py 87.93% <0.00%> (+1.72%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978579b...b04c98f. Read the comment docs.

@effigies effigies merged commit be9a98c into nipy:master Feb 12, 2020
@effigies effigies mentioned this pull request Feb 14, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants