Skip to content

fix: lack of result file raises internal error. closes #3088 #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

satra
Copy link
Member

@satra satra commented Jan 5, 2020

Summary

Fixes #3088 .

List of changes proposed in this PR (pull-request)

trap and return None when result file does not exist after a node exception in multiproc.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@satra satra closed this Jan 5, 2020
@codecov
Copy link

codecov bot commented Jan 5, 2020

Codecov Report

Merging #3142 into master will increase coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3142      +/-   ##
==========================================
+ Coverage   67.59%   67.62%   +0.03%     
==========================================
  Files         299      299              
  Lines       39480    39483       +3     
  Branches     5220     5220              
==========================================
+ Hits        26685    26699      +14     
+ Misses      12082    12072      -10     
+ Partials      713      712       -1
Flag Coverage Δ
#smoketests 53.01% <0%> (-0.01%) ⬇️
#unittests 64.86% <50%> (+0.02%) ⬆️
Impacted Files Coverage Δ
nipype/pipeline/plugins/multiproc.py 80.36% <50%> (-0.89%) ⬇️
nipype/interfaces/dcm2nii.py 64.78% <0%> (+6.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5e74f...8a356a4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results file failure with 1.3.0rc1 (MapNode)
1 participant