Allow nipype.cfg in cwd to be read even if ~/.nipype does not exist #3072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the nipype.cfg in the current directory would not be read if the folder ~/.nipype does not exist.
effigies
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Checking pydoc:
configparser.ConfigParser.read = read(self, filenames, encoding=None)
Read and parse a filename or an iterable of filenames.
Files that cannot be opened are silently ignored; this is
designed so that you can specify an iterable of potential
configuration file locations (e.g. current directory, user's
home directory, systemwide directory), and all existing
configuration files in the iterable will be read. A single
filename may also be given.
Return list of successfully read files.
LGTM.
|
Please merge/rebase master to fix the tests. |
Codecov Report
@@ Coverage Diff @@
## master #3072 +/- ##
==========================================
- Coverage 68.19% 68.19% -0.01%
==========================================
Files 297 297
Lines 39771 39770 -1
Branches 5210 5209 -1
==========================================
- Hits 27123 27121 -2
- Misses 11939 11940 +1
Partials 709 709
Continue to review full report at Codecov.
|
oesteban
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the nipype.cfg in the current directory would not
be read if the folder ~/.nipype does not exist.
Acknowledgment