-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: Delay etelemetry for non-interactive sessions, report bad versions #3049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
43183fb
enh: update to provide bad version info to users
satra ae2dddf
use result to determine output
satra d8411c1
enh: only display if versions are different
satra 861e52c
fix: syntax error
satra 72964f4
ref: make version checking it's own function
satra d86fa78
ENH: Run memoized check_version at REPL import, Node/Workflow/Interfa…
effigies c6bfab4
Merge pull request #30 from effigies/enh/et
satra 4516a8d
Merge remote-tracking branch 'upstream/master' into enh/et
satra 43669cc
fix: use lru_cache in py3
satra cf72c26
fix: version checking
satra f614ab9
fix: decorator and ref: check name
satra df34182
Merge remote-tracking branch 'upstream/master' into enh/et
satra 9c5d64b
enh: memoize with global
satra 7646796
use a class field limit rerunning check
satra f5bec39
store checked version in baseinterface
satra e9f553e
address review comments
satra fcbf57b
fix: allow networks without internet to check only once
satra 04e246f
Merge remote-tracking branch 'upstream/master' into enh/et
satra c7e3934
Merge remote-tracking branch 'upstream/master' into enh/et
satra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ "bad_versions" : [ "1.2.1", | ||
"1.2.3"] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be checked and updated before release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are legitimately buggy. We can really only plausibly check back to 1.3.0, since this functionality will be missing before that. Is it worth looking for critical bugs in earlier release logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was more about whether even these two were correct. from a usage perspective, nothing will change till the server starts reading these
.et
files and returning the info. i'll update the server soon.