Skip to content

ENH: Update MCFLIRT outputs for FSL 6+ #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Conversation

kimsin98
Copy link
Contributor

Summary

Fixes #2925 .

List of changes proposed in this PR (pull-request)

  • Fixes MCFLIRT output checks for FSL 6, which now uses more sensible extensions for intermediate output file names.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #3029 into master will decrease coverage by 0.02%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3029      +/-   ##
==========================================
- Coverage    67.5%   67.48%   -0.03%     
==========================================
  Files         344      344              
  Lines       44062    44087      +25     
  Branches     5553     5561       +8     
==========================================
+ Hits        29746    29753       +7     
- Misses      13570    13587      +17     
- Partials      746      747       +1
Flag Coverage Δ
#smoketests 50.28% <11.11%> (-0.01%) ⬇️
#unittests 64.94% <11.11%> (-0.03%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/fsl/preprocess.py 82.04% <11.11%> (-0.56%) ⬇️
nipype/interfaces/afni/preprocess.py 80.91% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967ef92...30df1a1. Read the comment docs.

@effigies effigies added this to the 1.2.3 milestone Sep 16, 2019
@effigies effigies changed the title [FIX] FSL 6+ specific fix for MCFLIRT outputs ENH: Update MCFLIRT outputs for FSL 6+ Sep 16, 2019
@effigies
Copy link
Member

Thanks!

@effigies effigies merged commit 1689fe5 into nipy:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSL 6.0 mcflirt mean_reg.nii.gz naming error?
3 participants