-
Notifications
You must be signed in to change notification settings - Fork 533
FIX: Use load_resultfile
when loading a results pickle
#2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some sections of the code were using ``loadpkl`` which does not resolve paths. This PR also improves ``loadpkl`` for readability and reliability.
fe5fa56
to
88b6fc0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2985 +/- ##
==========================================
- Coverage 67.6% 64.24% -3.36%
==========================================
Files 344 342 -2
Lines 43802 43741 -61
Branches 5478 5473 -5
==========================================
- Hits 29611 28101 -1510
- Misses 13475 14551 +1076
- Partials 716 1089 +373
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for breaking these fixes down into digestible PRs, and sorry for the delay.
One minor suggestion, but absolutely not a big deal. I can submit a separate PR.
Summary
Some sections of the code were using
filemanip.utils.loadpkl
, which does not resolve paths (probably dodging more frequent errors frommodify_paths
akin to #2944).These changes are spun off of #2971.
List of changes proposed in this PR (pull-request)
loadpkl
for readability and reliability.loadpkl
was used for reading result files instead ofpipeline.engine.utils.load_resultfile
.Acknowledgment