ENH: Do not override caught exceptions with FileNotFoundError from unfinished hashfile #2919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Apr 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #2919 +/- ##
=========================================
- Coverage 67.57% 64.2% -3.38%
=========================================
Files 343 341 -2
Lines 43645 43599 -46
Branches 5428 5427 -1
=========================================
- Hits 29494 27992 -1502
- Misses 13447 14526 +1079
- Partials 704 1081 +377
Continue to review full report at Codecov.
|
|
Thumbs-up? |
|
Lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR downgrades the situation to a debug trace. The rationale is that going through crash reports of fMRIPrep is really hard because this error shows up in a large portion of them.
This error (trying to remove the unfinished hashfile after some run time error has occurred) is likely to happen when two twin nipype workflows are competing in the same filesystem. Downgrading this to a debug trace will help split errors derived from race conditions and other errors.