[ENH] Add all DIPY workflows dynamically #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2905 +/- ##
=========================================
- Coverage 67.56% 67.5% -0.06%
=========================================
Files 343 344 +1
Lines 43604 43648 +44
Branches 5427 5438 +11
=========================================
+ Hits 29461 29466 +5
- Misses 13438 13471 +33
- Partials 705 711 +6
Continue to review full report at Codecov.
|
arokem
reviewed
Mar 29, 2019
nipype/interfaces/dipy/base.py
Outdated
| return [(m, obj) for m, obj in inspect.getmembers(module) | ||
| if inspect.isclass(obj) and | ||
| issubclass(obj, module.Workflow) and | ||
| m not in ['Workflow', 'CombinedWorkflow']] |
There was a problem hiding this comment.
As in dipy/dipy#1800, I suggest that you set this list to be a module-level constant.
BTW: the fact that you are using this same code there suggests that this might be a pattern worth including in the dipy library code, instead of here.
| @@ -33,9 +34,19 @@ | |||
| DTIModel = dipy_to_nipype_interface("DTIModel", ReconstDtiFlow) | |||
There was a problem hiding this comment.
Don't you want to remove these from here?
|
No problem @satra, I just did it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #2830. It permits to add automatically all DIPY workflows following your DIPY version. This should fix this comment from @arokem and @chrisfilo.
Originally, the goal was to fix this issue but thanks to @mgxd who already did it!
I tag @Garyfallidis and @satra just to keep them updated.