[TST] Improve py.test configuration of doctests #2802
Merged
+42
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that doctests are run OUTSIDE nipype's source directory in all the cases. Previously, doctests would chdir into the testing/data folder and some interfaces would generate results. Also, deletes ``nipype/testing/data/slice_timing.1D``, which seems to have seaked into the tree for these very reasons in some past PR.
Codecov Report
@@ Coverage Diff @@
## master #2802 +/- ##
==========================================
- Coverage 67.51% 64.12% -3.39%
==========================================
Files 341 339 -2
Lines 43297 43258 -39
Branches 5369 5366 -3
==========================================
- Hits 29230 27740 -1490
- Misses 13366 14451 +1085
- Partials 701 1067 +366
Continue to review full report at Codecov.
|
|
Tests are passing and coverage decreased because the #smoketests target was not received by codecov. I've checked and both travis and circle are giving exactly the same number of tests (passed, xfailed, skipped) before and after these changes. Merge? |
yarikoptic
added a commit
to yarikoptic/nipype
that referenced
this pull request
Jan 11, 2019
1.1.7 (December 17, 2018) * FIX: Copy node list before generating a flat graph (nipy#2828) * FIX: Update pytest req'd version to 3.6 (nipy#2827) * FIX: Set ResourceMonitor.fname to an absolute path (nipy#2824) * FIX: Order of SPM.NewSegment channel_info boolean tuple is (Field, Corrected) (nipy#2817) * FIX: Indices were swapped for memory and cpu profile data (nipy#2816) * FIX: ``status_callback`` not called with ``stop_on_first_crash`` (nipy#2810) * FIX: Change undefined ScriptError on LFS plugin to IOError (nipy#2803) * ENH: Add NaN failure mode to CompCor interfaces (nipy#2819) * ENH: Enable cnr_maps and residuals outputs for FSL eddy (nipy#2750) * ENH: Improve ``str2bool`` + doctests (nipy#2807) * TST: Improve py.test configuration of doctests (nipy#2802) * DOC: Update DOI badge to point to all versions (nipy#2804) * MAINT: Offload interfaces with help formatting (nipy#2797) * MAINT: Reduce minimal code redundancy in filemanip.get_dependencies (nipy#2782) * MAINT: Delayed imports to reduce import time (nipy#2809) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that doctests are run OUTSIDE nipype's source directory
in all the cases. Previously, doctests would chdir into the testing/data
folder and some interfaces would generate results.
Also, deletes
nipype/testing/data/slice_timing.1D, which seems tohave sneaked into the tree for these very reasons in some past PR.
This can be held out until next release after 1.1.6.
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment