Skip to content

ENH: Added support for Bru2's -z compress option #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

TheChymera
Copy link
Collaborator

@TheChymera TheChymera commented Oct 28, 2018

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies
Copy link
Member

Looks good. (Circle tests are failing for unrelated reasons.) Want to run make specs to update the auto test?

@codecov-io
Copy link

Codecov Report

Merging #2762 into master will decrease coverage by 3.39%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2762     +/-   ##
=========================================
- Coverage   67.44%   64.04%   -3.4%     
=========================================
  Files         340      338      -2     
  Lines       43170    43122     -48     
  Branches     5352     5350      -2     
=========================================
- Hits        29116    27618   -1498     
- Misses      13356    14438   +1082     
- Partials      698     1066    +368
Flag Coverage Δ
#smoketests ?
#unittests 64.04% <25%> (-0.77%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/bru2nii.py 70% <25%> (-4.08%) ⬇️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/freesurfer/base.py 49.59% <0%> (-30.9%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35.39% <0%> (-29.21%) ⬇️
nipype/interfaces/spm/base.py 58.41% <0%> (-29.05%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.99%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83b06d...46e659b. Read the comment docs.

@effigies effigies added this to the 1.1.4 milestone Oct 29, 2018
@effigies
Copy link
Member

Thanks!

@effigies effigies merged commit 502fc63 into nipy:master Oct 29, 2018
@TheChymera TheChymera deleted the bru2 branch October 29, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants