-
Notifications
You must be signed in to change notification settings - Fork 533
FIX: Python 2.7-3.7.1 compatible NonDaemonPool #2754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2754 +/- ##
==========================================
- Coverage 67.44% 63.99% -3.45%
==========================================
Files 340 338 -2
Lines 43164 43116 -48
Branches 5351 5348 -3
==========================================
- Hits 29110 27594 -1516
- Misses 13355 14444 +1089
- Partials 699 1078 +379
Continue to review full report at Codecov.
|
Relevant Travis tests: https://travis-ci.org/nipy/nipype/builds/446288741 @oesteban Any objections? I'm pretty sure the whole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Awesome! @effigies Thanks a lot its help me in my own project! |
Some Python versions replacing the standard Pool with our custom Pool causes the following error: "AssertionError: group argument must be None for now." [1] This change uses a different approach, solving this issue. [1]: nipy/nipype#2754
Some Python versions replacing the standard Pool with our custom Pool causes the following error: "AssertionError: group argument must be None for now." [1] This change uses a different approach, solving this issue. [1]: nipy/nipype#2754
Check nipy/nipype#2754 for more details Fixes ai4os#95
Check nipy/nipype#2754 for more details Fixes ai4os#95
Check nipy/nipype#2754 for more details Fixes ai4os#95
Check nipy/nipype#2754 for more details Fixes ai4os#95
Check nipy/nipype#2754 for more details Fixes #95
Fixes #2745.
Python 2.7, 3.4-3.7.0, and 3.7.1 all have different interpretations of
Pool.Process
.In Python 2.7, it's a class:
In Python 3.4-3.7.0, it's a method that calls
self._ctx.Process
:And now, in Python 3.7.1, it's a static method that takes a context: