[FIX] Lock travis pybids 0.6.5 #2720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelavega
force-pushed
the
pybids_travis
branch
from
ffd0d8e to
7d1bfd5
Compare
adelavega
force-pushed
the
pybids_travis
branch
from
1b5f99d to
96b9a8a
Compare
effigies
reviewed
Oct 9, 2018
| @@ -87,8 +87,7 @@ before_install: | |||
|
|
|||
| - travis_retry pip install -r requirements.txt | |||
| - travis_retry pip install grabbit==0.1.2 | |||
| - travis_retry git clone https://github.com/INCF/pybids.git ${HOME}/pybids && | |||
| pip install -e ${HOME}/pybids | |||
| - travis_retry git clone -b 0.6.5 https://github.com/INCF/pybids.git ${HOME}/pybids && pip install -e ${HOME}/pybids | |||
There was a problem hiding this comment.
Shorter:
travis_retry pip install -e git+https://github.com/INCF/pybids.git@0.6.5#egg=pybids
|
Shouldn't we also pin the dependency here? |
Codecov Report
@@ Coverage Diff @@
## master #2720 +/- ##
==========================================
- Coverage 67.61% 64.26% -3.35%
==========================================
Files 340 338 -2
Lines 43153 43102 -51
Branches 5351 5348 -3
==========================================
- Hits 29176 27701 -1475
- Misses 13275 14329 +1054
- Partials 702 1072 +370
Continue to review full report at Codecov.
|
|
Merging despite all the scary red x's. cc: @miykael. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a patch to attempt to pin pybids to 0.6.5, until we updates the interfaces that depend on pybids.