Skip to content

[FIX] Keep profile files with remove_unnecessary_outputs = true #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Oct 8, 2018

Close #2717

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0ef261c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2718   +/-   ##
=========================================
  Coverage          ?   67.61%           
=========================================
  Files             ?      340           
  Lines             ?    43153           
  Branches          ?     5351           
=========================================
  Hits              ?    29179           
  Misses            ?    13272           
  Partials          ?      702
Flag Coverage Δ
#smoketests 50.57% <ø> (?)
#unittests 65.08% <ø> (?)
Impacted Files Coverage Δ
nipype/pipeline/engine/utils.py 82.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef261c...e6e0625. Read the comment docs.

@effigies effigies merged commit 7f1a800 into master Oct 11, 2018
@effigies effigies deleted the oesteban-patch-1 branch October 11, 2018 15:09
@effigies effigies added this to the 1.1.4 milestone Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile files get clean up if remove_unnecessary_outputs = true
3 participants