RF: Use runtime.cwd in Rename #2688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2688 +/- ##
=========================================
- Coverage 67.6% 67.6% -0.01%
=========================================
Files 340 340
Lines 43145 43143 -2
Branches 5349 5349
=========================================
- Hits 29170 29168 -2
Misses 13273 13273
Partials 702 702
Continue to review full report at Codecov.
|
oesteban
reviewed
Aug 29, 2018
| os.path.join(os.getcwd(), self._rename())) | ||
| out_file = os.path.join(runtime.cwd, self._rename()) | ||
| _ = copyfile(self.inputs.in_file, out_file) | ||
| self._results['out_file'] = out_file |
There was a problem hiding this comment.
Now that the constructor of SimpleInterface is not called, then self._results should be initialized in __init__ as an empty dict, shouldn't it?
There was a problem hiding this comment.
Scratch that, I see that you are actually adding the SimpleInterface. For some reason I read the diff in the opposite way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename calculates the output path twice, in
_run_interfaceand_list_outputs. By moving toSimpleInterface, we can calculate the path once, and useruntime.cwdas insurance against unexpected working directory changes.Fixes #2687.
List of changes proposed in this PR (pull-request)
SimpleInterfaceas mixin toRenameruntime.cwdAcknowledgment