-
Notifications
You must be signed in to change notification settings - Fork 533
CI: Stop using Miniconda on Travis #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The failing test is related to the new numpy formatting. nipype/nipype/interfaces/image.py Lines 63 to 78 in a882e74
I'm not really sure why this wouldn't have appeared under I guess the question is whether to change the test or update print options like so. |
perhaps we can do something through the pytest config, just like we are doing doctests? we could also update the test to use our own format without relying on numpy. |
Codecov Report
@@ Coverage Diff @@
## master #2600 +/- ##
==========================================
+ Coverage 67.62% 67.62% +<.01%
==========================================
Files 339 339
Lines 42787 42787
Branches 5288 5288
==========================================
+ Hits 28934 28936 +2
+ Misses 13171 13168 -3
- Partials 682 683 +1
Continue to review full report at Codecov.
|
7cd2137
to
1ea55de
Compare
Yeah. Apparently the details of the effective formatting change vary by what version of Python the wheel was compiled for (while |
Passing Travis. |
Hmm. Sphinx's |
It's an indentation effect. Is it acceptable to have a de-indented docstring? |
@effigies - sorry didn't see this earlier. if it's necessary, it's necessary. looks darn ugly though :( |
Yeah. Could be possible to fix up the Sphinx extension, but that's beyond my current ambitions. |
152a444
to
eca32f6
Compare
Actually, I think all but one |
Suggested in #2598. Will allow us to test more vanilla installations of Python.
Should speed up Travis builds, too.