Skip to content

FIX: Update logging levels in enable_debug_mode #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2018

Conversation

effigies
Copy link
Member

Fixes #1169

Changes proposed in this pull request

  • Update logging levels in enable_debug_mode
  • Add a test

@effigies effigies added this to the 1.0.4 milestone May 25, 2018
@effigies effigies requested a review from chrisgorgo May 25, 2018 01:03
@satra
Copy link
Member

satra commented May 25, 2018

i don't think this was really a bug. if we treat it as such (and i am fine with the change) we should update this as well:

http://nipype.readthedocs.io/en/latest/users/config_file.html#debug-configuration

@effigies
Copy link
Member Author

It does seem weird to enable_debug_mode and only change the config without changing the log levels the config refers to.

That said, if utils_level wasn't intended to be part of it, I'm okay with removing that. That may be too noisy. Will update the docs.

@codecov-io
Copy link

codecov-io commented May 25, 2018

Codecov Report

Merging #2595 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2595      +/-   ##
==========================================
+ Coverage   67.62%   67.63%   +<.01%     
==========================================
  Files         336      336              
  Lines       42711    42714       +3     
  Branches     5278     5278              
==========================================
+ Hits        28883    28889       +6     
+ Misses      13151    13148       -3     
  Partials      677      677
Flag Coverage Δ
#smoketests 50.77% <100%> (+0.02%) ⬆️
#unittests 65.11% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
nipype/utils/config.py 66.84% <100%> (+0.54%) ⬆️
nipype/utils/profiler.py 43.1% <0%> (-1.15%) ⬇️
nipype/utils/logger.py 87.3% <0%> (+7.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eaa2a3...785bdf4. Read the comment docs.

@satra
Copy link
Member

satra commented May 25, 2018

also this docs: http://nipype.readthedocs.io/en/latest/users/debug.html

so we did have proper instructions for debug mode.

i would use this opportunity to clean up and make debug mode as useful as possible. so go ahead with your changes.

@effigies
Copy link
Member Author

Any further comments? Hoping to merge these last four PRs in batch when @mgxd's tests pass.

@effigies effigies modified the milestones: 1.0.4, 1.1.0 May 26, 2018
@satra
Copy link
Member

satra commented May 26, 2018

lgtm

@effigies effigies modified the milestones: 1.1.0, 1.0.4 May 27, 2018
@effigies effigies merged commit a882e74 into nipy:master May 27, 2018
@effigies effigies deleted the fix/debug_mode branch May 27, 2018 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants