-
Notifications
You must be signed in to change notification settings - Fork 533
FIX: Update logging levels in enable_debug_mode #2595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i don't think this was really a bug. if we treat it as such (and i am fine with the change) we should update this as well: http://nipype.readthedocs.io/en/latest/users/config_file.html#debug-configuration |
It does seem weird to That said, if |
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
==========================================
+ Coverage 67.62% 67.63% +<.01%
==========================================
Files 336 336
Lines 42711 42714 +3
Branches 5278 5278
==========================================
+ Hits 28883 28889 +6
+ Misses 13151 13148 -3
Partials 677 677
Continue to review full report at Codecov.
|
also this docs: http://nipype.readthedocs.io/en/latest/users/debug.html so we did have proper instructions for debug mode. i would use this opportunity to clean up and make debug mode as useful as possible. so go ahead with your changes. |
Any further comments? Hoping to merge these last four PRs in batch when @mgxd's tests pass. |
lgtm |
Fixes #1169
Changes proposed in this pull request