-
Notifications
You must be signed in to change notification settings - Fork 533
ENH: Reorient interface #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Reorient interface #2572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2572 +/- ##
==========================================
+ Coverage 67.57% 67.59% +0.02%
==========================================
Files 333 334 +1
Lines 42547 42598 +51
Branches 5266 5273 +7
==========================================
+ Hits 28750 28796 +46
- Misses 13124 13126 +2
- Partials 673 676 +3
Continue to review full report at Codecov.
|
+1000, and I think the new module is fine. |
Well, hoped to get #2576 to test the nibabel fallback code, but that's not likely to happen. This should be good to go. |
Seems like some tests are failing in Travis. Particularly, when checking that the affine was actually changed. Seems like (0, 1, 2) affines are being set? |
Ah, no. This is the case where there's a flip but not a reordering. The dimension info doesn't include direction, just axis. |
@oesteban Good to merge? |
This is a pure nibabel/numpy interface to reorient an image to any
RAS
...IPL
. It also produces an affine transform that describes the reorientation.Based off of
fmriprep.interfaces.images.Reorient
, but does not assume RAS target orientation or nibabel >= 2.2.I created a
interfaces.image
file, since this didn't seem to fall into existing interface categories. Is there a better place to put this?