Skip to content

FIX/TEST: Gunzip cleanup and test #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2018
Merged

FIX/TEST: Gunzip cleanup and test #2564

merged 1 commit into from
May 1, 2018

Conversation

effigies
Copy link
Member

@effigies effigies commented May 1, 2018

Following Neurostars #1623, I checked on the nipype Gzip implementation. Apparently I misremembered, because I found Gunzip instead. Anyway, here are some cleanups and a doctest.

Changes proposed in this pull request

  • FIX: _gen_output_file_name had a bad test for .gz extension
  • ENH: Use shutil.copyfileobj to ensure more memory-friendly buffering
  • TEST: Add doctest to demonstrate usage and verify filename change

FIX: _gen_output_file_name had a bad test for .gz extension
ENH: Use shutil.copyfileobj to ensure more memory-friendly buffering
TEST: Add doctest to demonstrate usage and verify filename change
@effigies effigies added this to the 1.0.4 milestone May 1, 2018
@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #2564 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
+ Coverage   67.13%   67.13%   +<.01%     
==========================================
  Files         333      333              
  Lines       42542    42543       +1     
  Branches     5265     5265              
==========================================
+ Hits        28560    28562       +2     
+ Misses      13280    13279       -1     
  Partials      702      702
Flag Coverage Δ
#smoketests 50.71% <100%> (ø) ⬆️
#unittests 64.47% <75%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/algorithms/misc.py 45.97% <100%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda8fa1...6a98617. Read the comment docs.

@mgxd mgxd merged commit 347c4b4 into nipy:master May 1, 2018
@effigies effigies deleted the fix/gunzip branch May 1, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants