Skip to content

FIX: Typo in "antsRegistrationSyNQuick.sh" #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Conversation

effigies
Copy link
Member

Fixes #2543.

Changes proposed in this pull request

  • antsRegistrationSynQuick.sh -> antsRegistrationSyNQuick.sh (note the "n" in "Syn")

I've checked back several versions of ANTs, and the script didn't change names. We just had a typo.

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one more spelling correction

input_spec = RegistrationSynQuickInputSpec
output_spec = RegistrationSynQuickOutputSpec

def _num_threads_update(self):
"""
antsRegistrationSynQuick.sh ignores environment variables,
antsRegistrationSyNQuick.sh ignores environment variables,
so override environment update frm ANTSCommand class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from ANTSCommand

@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

Merging #2544 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
- Coverage   67.04%   67.03%   -0.01%     
==========================================
  Files         332      332              
  Lines       42516    42516              
  Branches     5265     5265              
==========================================
- Hits        28505    28501       -4     
- Misses      13308    13312       +4     
  Partials      703      703
Flag Coverage Δ
#smoketests 50.67% <100%> (ø) ⬆️
#unittests 64.34% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/ants/registration.py 74.22% <100%> (ø) ⬆️
nipype/pipeline/plugins/multiproc.py 79.76% <0%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a9c85...1ce0b28. Read the comment docs.

@effigies effigies added this to the 1.0.3 milestone Apr 17, 2018
@effigies effigies merged commit bcf2a52 into master Apr 17, 2018
@effigies effigies deleted the fix/regsynquick_typo branch April 17, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants