CI: Add doctests to pytest script #2449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2449 +/- ##
=========================================
+ Coverage 59.78% 66.78% +7%
=========================================
Files 328 328
Lines 42456 42456
Branches 5275 5275
=========================================
+ Hits 25382 28356 +2974
+ Misses 16691 13412 -3279
- Partials 383 688 +305
Continue to review full report at Codecov.
|
effigies
commented
Feb 18, 2018
| py.test -v --junitxml=${WORKDIR}/tests/pytests_py${PYTHON_VERSION}.xml \ | ||
| --cov nipype --cov-config /src/nipype/.coveragerc \ | ||
| --cov-report xml:${WORKDIR}/tests/coverage_py${PYTHON_VERSION}.xml \ | ||
| -c ${TESTPATH}/pytest.ini ${TESTPATH} |
There was a problem hiding this comment.
Critical bit here is the -c.
|
Looks like we weren't running doctests on Circle, so they were missing from coverage. Doesn't seem to add to test runtime, so I'll go ahead and merge. |
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a PR just to get Circle moving. I'm not sure if this will make any difference to coverage.