Skip to content

[WIP] COV: Ignore tests in calculating coverage #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2018
Merged

Conversation

effigies
Copy link
Member

This is an attempt to get more accurate coverage reports. Follow-up to #2386, which re-enabled codecov uploads. Will update the following list to reflect steps taken.

  1. Removing tests directories, to reduce noise in report

@effigies
Copy link
Member Author

Looks like we're still not updating codecov properly for pull requests. https://codecov.io/gh/nipy/nipype/pulls

@satra
Copy link
Member

satra commented Feb 16, 2018

@effigies - i added the codecov token to circle environment variables. let's see if that helps. do you mind retriggering this PR?

@effigies
Copy link
Member Author

Doesn't seem to have.

codecov.yml Outdated
@@ -26,3 +26,4 @@ coverage:
- "nipype/external/*"
- "tools/*"
- "doc/*"
- "**/tests"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add examples to this list. we don't need to see which lines in examples are covered.

@satra
Copy link
Member

satra commented Feb 17, 2018

@effigies - i'll check the logs more closely in the codecov lines.

@satra
Copy link
Member

satra commented Feb 17, 2018

it looks like it did upload - also it says token not required for public repos uploading from circle ci

@effigies
Copy link
Member Author

Yeah, they're uploading, but not getting associated with the pull requests. #2446 is, though, presumably because it's saying nipy/nipype, not effigies/nipype. I'll try modifying the slug.

@effigies
Copy link
Member Author

Nope, that causes a validation error.

@effigies
Copy link
Member Author

@satra If you're more familiar with codecov, feel free to push to this branch. I've taken a few stabs at figuring this out, and unless it's something that fixes itself on new PRs after a few bumps to master, I'm completely stumped. I've checked the logs for the individual pushes, and there's no clear error.

@satra
Copy link
Member

satra commented Feb 17, 2018

i can't see a clear picture here. i have gone through the logs as well. some of them are generating a Github 404 error in trying to get info about a commit. let me merge this in so that master coverage is cleaned up. and i will open a separate issue to track the PR issue.

@satra satra closed this Feb 17, 2018
@satra satra reopened this Feb 17, 2018
@satra satra merged commit acd1a4c into nipy:master Feb 17, 2018
@effigies effigies deleted the coverage branch February 17, 2018 20:58
@effigies effigies added this to the 1.0.1 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants