[FIX] Bug fixes for afni.model #2398
Conversation
Patches cbucket output for 3dDeconvolve, correctly parses output of 3dSynthesize.
|
Thanks for this. I'm canceling this CI job for the moment. I'll restart it when some high priority jobs finish. |
| outputs['reml_script'] = self._gen_fname( | ||
| suffix='.REML_cmd', **_gen_fname_opts) | ||
| # remove out_file from outputs if x1d_stop set to True | ||
| if self.inputs.x1D_stop: | ||
| del outputs['out_file'] | ||
| del outputs['out_file'], outputs['cbucket'] |
There was a problem hiding this comment.
if I may, test_extra_Deconvolve.py could be extended to check for the removal of outputs['cbucket']
There was a problem hiding this comment.
@emdupre nothing is building right now and won't probably merge anything more. feel free to use circle, we can always cancel.
There was a problem hiding this comment.
Was going to say what @djarecka said. CI is not really the submitter's problem and we can cancel and restart as needed. I just try to give a heads up when doing that.
There was a problem hiding this comment.
Great, thanks for clarifying !
| assert not 'out_file' in deconv._list_outputs() | ||
| assert not 'cbucket' in deconv._list_outputs() |
There was a problem hiding this comment.
The syntax x not in y is preferred to not x in y. Could you change both of these lines?
There was a problem hiding this comment.
Patched and rebased into the previous commit!
|
LGTM 👍 |
Changes proposed in this pull request