Fix 3dFWHMx outputs #2373
Merged
Fix 3dFWHMx outputs #2373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
approved these changes
Jan 15, 2018
nipype/interfaces/afni/utils.py
Outdated
|
|
||
| # handle newer versions of AFNI | ||
| if sout.size == 8: | ||
| outputs['fwhm'] = tuple(sout[0,:]) |
There was a problem hiding this comment.
missing space after comma
nipype/interfaces/afni/utils.py
Outdated
| outputs['fwhm'] = tuple(sout[0,:]) | ||
| else: | ||
| outputs['fwhm'] = tuple(sout) | ||
|
|
||
| if self._acf: | ||
| outputs['acf_param'] = tuple(sout[1]) |
There was a problem hiding this comment.
wouldn't this be appropriate to set if sout.size == 8 as well?
oesteban
reviewed
Jan 16, 2018
nipype/interfaces/afni/utils.py
Outdated
| else: | ||
| outputs['fwhm'] = tuple(sout) | ||
|
|
||
| if self._acf: | ||
| assert sout.size == 8, "Wrong number of elements in %s"%str(sout) |
There was a problem hiding this comment.
spaces around %, otherwise looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nipreps/mriqc#677
Changes proposed in this pull request