Skip to content

[FIX] GraphPluginBase error in Python #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2018

Conversation

mfalkiewicz
Copy link
Contributor

Fixes #2353

Python 3 creates generators instead of lists, which breaks the GraphPluginBase class. It does not allow to submit jobs with SLURMGraph plugin.

@mfalkiewicz mfalkiewicz changed the title [FIX] GraphPluginBase error in Python 3 #2353 [FIX] GraphPluginBase error in Python Jan 7, 2018
@oesteban oesteban added this to the 0.14.1 milestone Jan 7, 2018
@oesteban
Copy link
Contributor

oesteban commented Jan 8, 2018

@mfalkiewicz would you mind adding an entry to the CHANGES file? Also, if you commit with [skip ci] in the first line of the commit message, we can avoid re-running all tests and merge directly.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@80d3f05). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2359   +/-   ##
=========================================
  Coverage          ?   52.19%           
=========================================
  Files             ?      122           
  Lines             ?    24393           
  Branches          ?        0           
=========================================
  Hits              ?    12731           
  Misses            ?    11662           
  Partials          ?        0
Flag Coverage Δ
#smoketests 52.19% <0%> (?)
Impacted Files Coverage Δ
nipype/pipeline/plugins/base.py 38.92% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d3f05...a29f347. Read the comment docs.

@effigies
Copy link
Member

We can update CHANGES before releasing. Happy to merge on tests passing.

@effigies effigies merged commit 157d3bd into nipy:master Jan 19, 2018
@effigies effigies modified the milestones: 0.14.1, 1.0 Jan 19, 2018
@mfalkiewicz mfalkiewicz deleted the fix_plugin_base_p3 branch February 2, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants