small changes in FSSourceInputSpec (fixes #2116) #2349
Conversation
nipype/interfaces/tests/test_io.py
Outdated
| @@ -407,6 +407,13 @@ def test_freesurfersource(): | |||
| assert fss.inputs.subjects_dir == Undefined | |||
|
|
|||
|
|
|||
| def test_freesurfersource_incorrectdir(): | |||
| fss = nio.FreeSurferSource() | |||
| with pytest.raises(Exception) as err: | |||
There was a problem hiding this comment.
Doesn't it work using with pytest.raises(TraitError) ?
There was a problem hiding this comment.
you're right, after importing TraitError it works...
|
this is a bit weird: why the only changing specs are unrelated to freesurfer? I'd expect FS' interfaces to change... WDYT? |
|
Maybe @satra will correct me, but the idea for the auto tests is to be updated with the PR that modifies interfaces, so that we clearly see how the interface changed. Is that correct? If so, then we would need to keep both PRs separate and update specs accordingly. |
|
@oesteban - not sure if I understand your point. I didn't mix my PRs, I only wrote that I had exactly the same problem in my other PR, i.e., My guess was that simply |
This reverts commit ba9ae4f.
|
@effigies yes |
adding exists=True for subjects_dir in FSSourceInputSpec
fixes #2116