FIX: PBS plugin fix #2344
Merged
FIX: PBS plugin fix #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achetverikov this LGTM - don't forget to add yourself to the |
oesteban
reviewed
Dec 22, 2017
nipype/pipeline/plugins/pbs.py
Outdated
| @@ -47,18 +47,20 @@ def __init__(self, **kwargs): | |||
| super(PBSPlugin, self).__init__(template, **kwargs) | |||
|
|
|||
| def _is_pending(self, taskid): | |||
| result = CommandLine('qstat {}'.format(taskid), | |||
| result = CommandLine('qstat -f {}'.format(taskid), | |||
| environ=dict(os.environ), | |||
| terminal_output='allatonce', | |||
There was a problem hiding this comment.
I would suggest changing terminal_output to 'file_split'
There was a problem hiding this comment.
@oesteban why? & where can I read about file_split, it seems to be not documented yet (http://nipype.readthedocs.io/en/latest/interfaces/generated/interfaces.base/core.html#parameters)?
There was a problem hiding this comment.
@achetverikov you can read about terminal outputs here
http://nipype.readthedocs.io/en/latest/devel/interface_specs.html#controlling-outputs-to-terminal
|
ping @achetverikov - this is very close to merge |
achetverikov
force-pushed
the
pbs_plugin_fix
branch
from
cbbeed7 to
b10062f
Compare
|
Changed PBS plugin output to file_split as suggested by @oesteban |
|
@mgxd Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2343.
Changes proposed in this pull request