Skip to content

ENH: Extended MRtrix3 interface #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 97 commits into from

Conversation

matteomancini
Copy link
Contributor

Changes proposed in this pull request:

  • Added interfaces to mrconvert, dwiextract and mrmath (for operations on single images) not previously included in the mrtrix3 interfaces;
  • Updated interfaces to 5ttgen, dwi2response and dwi2fod taking into account the new syntax in the latest releases of MRtrix3 and offering the chance to use multi-tissue constrained spherical deconvolution.

oesteban and others added 30 commits November 13, 2017 23:31
@matteomancini
Copy link
Contributor Author

I see again some conflicts (not present before) that I am not able to resolve. Do I need to merge master again?

@satra
Copy link
Member

satra commented Dec 12, 2017

@matteomancini - yes - my worry with the previous set of changes is that it seemed to revert changes in master. so one option is to merge with master, resolve any conflicts and then push here. if the changes look fine great. if they look like they are reverting some intended changes (such as adding spaces, where there shouldn't be), then close and start another PR.

@effigies
Copy link
Member

This looks like one of those weird GitHub issues. Running a diff from this branch to master on the command line is much more reasonable.

I'm closing this PR. @matteomancini can you open a new PR on the same branch? It should have a much simpler diff.

@matteomancini
Copy link
Contributor Author

The issue was committing the changes without the last check-before-commit, the last commit ("fixed tests") was correct. In any case, I opened a new PR: #2338

@effigies effigies modified the milestones: 0.14.1, 1.0 Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants