-
Notifications
You must be signed in to change notification settings - Fork 533
BF: Run make specs
with CWD in PYTHONPATH
#1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Might as well run |
Codecov Report
@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
+ Coverage 72.71% 73.09% +0.38%
==========================================
Files 1059 1064 +5
Lines 52550 53316 +766
==========================================
+ Hits 38212 38972 +760
- Misses 14338 14344 +6
Continue to review full report at Codecov.
|
0ecb22a
to
af5e99a
Compare
@satra Do you want to have a quick look? This is just a quick fixup to make |
@@ -38,9 +38,9 @@ def test_Eddy_inputs(): | |||
mandatory=True, | |||
), | |||
in_topup_fieldcoef=dict(argstr='--topup=%s', | |||
requires=['in_topup_movpar'], | |||
requires=[u'in_topup_movpar'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the primary reason we were using python 2 was because of unicode issues. however, if we include unicode_literals
at the top of template, we can generate the same tests from either py2 or py3 by modifying the test generator a bit.
the main point of these auto-tests were to create an easy visual check for changes in input/outputspec api and to instantiate each object in the absence of consistent doctests. the former we can capture through a good PR review. the latter would require some work to go through all interfaces. so if we can achieve these two things somehow, it would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7ff705f makes py2/py3 behavior equivalent. I'm not entirely sure what you're suggesting for instantiating each object... Does the current system not do that?
813ccf7
to
8f69895
Compare
Not an expert at Makefiles, so this may not be the best way to go about this, but it does seem to set the PYTHONPATH so that
make specs
is run on the working directory, rather than an installednipype
.Fixes #1348.