Skip to content

deprecated traits in BaseInterfaceInputSpec and CommandLineInputSpec #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djarecka opened this issue Apr 25, 2018 · 5 comments
Closed

deprecated traits in BaseInterfaceInputSpec and CommandLineInputSpec #2551

djarecka opened this issue Apr 25, 2018 · 5 comments

Comments

@djarecka
Copy link
Collaborator

djarecka commented Apr 25, 2018

Summary

we have two traits that are marked ad deprecated='1.0.0' in interfaces/base/specs.py:

At the same time we're using these traits in some plugins, e.g. here and it leads to errors

I'm not sure why we wanted to deprecate these traits, and if we still want to do it now, or we want to set a different nipype version.

Related to #2508

@effigies
Copy link
Member

Yeah, I think we should remove those. I believe the justification for deprecation was that they were more properly attributes of an interface or node, rather than inputs.

@effigies
Copy link
Member

I'm actually a little surprised that these aren't throwing errors in our tests as of 1.0. And to be clear, I think we should remove them ASAP. Setting 1.0.3 milestone.

@effigies effigies added this to the 1.0.3 milestone Apr 25, 2018
@djarecka
Copy link
Collaborator Author

I didn't check everything carefully, but there are not in all plugins, and I don't think we test e.g. condor plugin

@djarecka
Copy link
Collaborator Author

I can remove ignore_exception=True from condor, lsf and pbs; terminal_output is set in couple more places.

@effigies
Copy link
Member

Seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants