-
Notifications
You must be signed in to change notification settings - Fork 260
CI: Migrate to GitHub actions #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## maint/3.2.x #972 +/- ##
===============================================
+ Coverage 91.81% 91.85% +0.03%
===============================================
Files 101 101
Lines 12550 12550
Branches 2209 2209
===============================================
+ Hits 11523 11528 +5
+ Misses 686 683 -3
+ Partials 341 339 -2
Continue to review full report at Codecov.
|
Windows failures
I don't have a Windows machine to test with. Will ping the Riot to see if anybody does. Pre-release failures#968 - waiting on tonight's scipy build |
c8ef497
to
bb431a5
Compare
d61a78e
to
e042456
Compare
This is only failing on pre-releases, now, due to scipy's nightlies. With Travis being what it is, I'm not sure we should wait on those getting fixed. Anybody care to review? (@yarikoptic?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @effigies,
Nice Job! Overall it looks good to me, I just have a small suggestion:
Even if I love Github Actions, one important feature is missing: restart only one failed job. If a matrix failed for whatever reason, you have to restart them all... not convenient and take time... (even if nibabel tests are short).
Because of that, I would suggest splitting test.yml
into 3 files, like test_experimental.yml
, test.yml
, and whatever.yml
.
Pros: if one matrice failed, you restart only a small bunch of them
cons: code duplication.
Let me know what you think.
bb36fcd
to
21624b3
Compare
21624b3
to
475ae88
Compare
@skoudoro Thanks for the suggestion. Broken into three groups:
Let me know if you have any other suggestions. |
Thanks for the thumbs up. I'm going to go ahead and merge to get tests going again. Curious when Travis will reset our counter... |
This shifts the majority of CI from Travis to GitHub Actions, and eliminates Azure Pipelines. Azure does not run on maintenance branches, and Travis is now moving to limit builds. Travis is reduced to ARM64 builds.
Part of this effort refactored the Travis scripts to a set of scripts that are hopefully a bit more abstracted from the details of any particular CI, as long as the CI supports bash. Each script should be
source
able or runnable as a standalone script.The environment variables were the most painful thing to port over. There's probably a better way to do this, and I'm happy to hear any suggestions from those more familiar with Actions.
Closes #971.