This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Nipype syntax change #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 'out' prefix was removed from the eddy quad interface in nipype v1.1.8. Should 'out' be re-added to nipype or removed from dmriprep? |
|
Maybe someone could explain to me why this syntax was changed? If need be, we might support both here, but if there was a good reason to remove it from nipype, I don't think that it needs to be reintroduced just for this. |
|
Thanks. That helps. I say let's not include the "out_" prefixes. Or in other words, we should revert this PR. |
|
Implemented in #69 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.