Skip to content

TEST: Verify LegacyMultiProc functionality #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2018

Conversation

effigies
Copy link
Member

@effigies effigies commented Nov 6, 2018

Changes proposed in this pull request

  • Add a legacy.yml plugin configuration to the Circle directory
  • Run full ds005 with LegacyMultiProc
  • Upgrade to nipype>=1.1.5

Closes #1363.

Documentation that should be reviewed

@effigies
Copy link
Member Author

effigies commented Nov 6, 2018

Reproducing #1363. cc @markushs

@effigies effigies force-pushed the ci/test_legacymultiproc branch from 1a159df to 86d2c63 Compare November 8, 2018 13:47
@effigies effigies changed the title CI: Use LegacyMultiProc to run ds005 TEST: Verify LegacyMultiProc functionality Nov 8, 2018
@effigies effigies merged commit 0c96887 into nipreps:master Nov 8, 2018
@markushs
Copy link
Contributor

markushs commented Nov 8, 2018

Nice! I reproduced the error locally using docker (as you asked in #1363) ~1 minute ago, but seems like you solved it without that info.

@effigies
Copy link
Member Author

effigies commented Nov 8, 2018

Yup. I hope to have a fixed release out today or tomorrow. For your other issue (#1365), we need to upgrade niworkflows, which might have a few kinks to work out.

@effigies effigies deleted the ci/test_legacymultiproc branch November 8, 2018 14:59
@effigies effigies added this to the 1.2.2 milestone Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin-fix for memory issues fails in 1.2.1
2 participants