Skip to content

SepReader.Cols: Add JoinPathsToString (net9.0+ only due to Path.Join(Span<>) only) #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

nietras
Copy link
Owner

@nietras nietras commented Jan 31, 2025

No description provided.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.63%. Comparing base (8429e4f) to head (3d27f04).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Sep/SepReaderState.cs 97.56% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   99.65%   99.63%   -0.02%     
==========================================
  Files          54       54              
  Lines        4297     4339      +42     
  Branches      493      503      +10     
==========================================
+ Hits         4282     4323      +41     
  Misses         12       12              
- Partials        3        4       +1     
Flag Coverage Δ
Debug 99.35% <97.72%> (-0.02%) ⬇️
Release 99.73% <100.00%> (+<0.01%) ⬆️
macos-latest 93.36% <97.72%> (+0.04%) ⬆️
ubuntu-latest 99.51% <97.72%> (-0.02%) ⬇️
windows-latest 99.51% <97.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nietras nietras merged commit 6b7aa58 into main Jan 31, 2025
33 of 34 checks passed
@nietras nietras deleted the sepreader-cols-joinpaths branch January 31, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant