-
Notifications
You must be signed in to change notification settings - Fork 43
Add SepWriter.DisableColCountCheck/ColNotSetOption #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #72 --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/nietras/Sep/issues/72?shareId=XXXX-XXXX-XXXX-XXXX).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 99.55% 99.58% +0.02%
==========================================
Files 47 47
Lines 3587 3602 +15
Branches 400 403 +3
==========================================
+ Hits 3571 3587 +16
+ Misses 14 13 -1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* **SepWriter.cs** - Add `_disableColCountCheck` field to `SepWriter` class. - Initialize `_disableColCountCheck` in the constructor using `SepWriterOptions`. - Update `EndRow` method to skip column count check if `_disableColCountCheck` is true. * **SepWriterOptions.cs** - Add `DisableColCountCheck` property to `SepWriterOptions` record. - Initialize `DisableColCountCheck` to false by default. * **SepWriterOptionsTest.cs** - Add test method to verify the default value of `DisableColCountCheck`. * **SepWriterTest.cs** - Add test method to verify `SepWriter` behavior when `DisableColCountCheck` is true. - Add additional test cases for various scenarios with `DisableColCountCheck`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #72
Fix #164