Skip to content

Add SepWriter.DisableColCountCheck/ColNotSetOption #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 11, 2025

Conversation

nietras
Copy link
Owner

@nietras nietras commented Jan 3, 2025

Fix #72
Fix #164

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (4ebd2c6) to head (403f77b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   99.55%   99.58%   +0.02%     
==========================================
  Files          47       47              
  Lines        3587     3602      +15     
  Branches      400      403       +3     
==========================================
+ Hits         3571     3587      +16     
+ Misses         14       13       -1     
  Partials        2        2              
Flag Coverage Δ
Debug 99.41% <100.00%> (+0.03%) ⬆️
Release 99.84% <100.00%> (+<0.01%) ⬆️
macos-latest 92.19% <100.00%> (+0.06%) ⬆️
ubuntu-latest 99.55% <100.00%> (+0.02%) ⬆️
windows-latest 99.55% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* **SepWriter.cs**
  - Add `_disableColCountCheck` field to `SepWriter` class.
  - Initialize `_disableColCountCheck` in the constructor using `SepWriterOptions`.
  - Update `EndRow` method to skip column count check if `_disableColCountCheck` is true.

* **SepWriterOptions.cs**
  - Add `DisableColCountCheck` property to `SepWriterOptions` record.
  - Initialize `DisableColCountCheck` to false by default.

* **SepWriterOptionsTest.cs**
  - Add test method to verify the default value of `DisableColCountCheck`.

* **SepWriterTest.cs**
  - Add test method to verify `SepWriter` behavior when `DisableColCountCheck` is true.
  - Add additional test cases for various scenarios with `DisableColCountCheck`.
@nietras nietras changed the title Implement SepWriter.DisableColCountCheck Add SepWriter.DisableColCountCheck/ColNotSetOption Jan 11, 2025
@nietras nietras merged commit c4107e5 into main Jan 11, 2025
35 checks passed
@nietras nietras deleted the implement-disable-col-count-check branch January 11, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to assume null for unset cells Implement SepWriter.DisableColCountCheck (true)
1 participant