Skip to content

Disallow synchronous handlers in type definition #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Disallow synchronous handlers in type definition #308

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
282959e
fix: narrow type of BaseHandler
Pimm Jan 16, 2022
2979653
Merge branch 'main' into main
Skn0tt Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/function/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface HandlerCallback<ResponseType extends Response = Response> {
}

export interface BaseHandler<ResponseType extends Response = Response, C extends Context = Context> {
(event: Event, context: C, callback: HandlerCallback<ResponseType>): void | ResponseType | Promise<ResponseType>
(event: Event, context: C, callback: HandlerCallback<ResponseType>): void | Promise<ResponseType>
}

export type Handler = BaseHandler<Response, Context>
Expand Down