Skip to content

fix(handler type): make callback parameter optional #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
+3 −3
Merged

fix(handler type): make callback parameter optional #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/function/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface HandlerCallback<ResponseType extends Response = Response> {
}

export interface BaseHandler<ResponseType extends Response = Response, C extends Context = Context> {
(event: Event, context: C, callback: HandlerCallback<ResponseType>): void | ResponseType | Promise<ResponseType>
(event: Event, context: C, callback?: HandlerCallback<ResponseType>): void | ResponseType | Promise<ResponseType>
}

export type Handler = BaseHandler<Response, Context>
Expand Down
4 changes: 2 additions & 2 deletions src/lib/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const augmentResponse = (response: BuilderResponse) => {
const wrapHandler =
(handler: BuilderHandler): Handler =>
// eslint-disable-next-line promise/prefer-await-to-callbacks
(event: HandlerEvent, context: HandlerContext, callback: HandlerCallback<Response>) => {
(event: HandlerEvent, context: HandlerContext, callback?: HandlerCallback<Response>) => {
if (event.httpMethod !== 'GET' && event.httpMethod !== 'HEAD') {
return Promise.resolve({
body: 'Method Not Allowed',
Expand All @@ -37,7 +37,7 @@ const wrapHandler =
}

// eslint-disable-next-line promise/prefer-await-to-callbacks
const wrappedCallback = (error: unknown, response: BuilderResponse) => callback(error, augmentResponse(response))
const wrappedCallback = (error: unknown, response: BuilderResponse) => callback?.(error, augmentResponse(response))
const execution = handler(modifiedEvent, context, wrappedCallback)

if (isPromise(execution)) {
Expand Down