Add support to Netbox _choice api for Circuits/DCIM/IPAM/Secrets/Tenancy/Virtualization #53
Conversation
Use json.RawMessage as value type to accommodate different type of value. User can json.Unmarshal Value with proper type when using it. This is the simplest way to support Netbox _choice apis I think. I can give a code example for this if needed
current value with Netbox saved value
|
We are currently trying to get this project into a state where we can fully generate models and a low level client from a swagger definition: Might it be possible to get your changes out of that effort? We are also thinking about a higher level client that will provide the appropriate unmarshaling for those cases of polymorphism |
|
Sorry, I'm not very familiar with swagger, If you've already had a plan to do this part, I'm looking forward to that. |
|
Can you give me some example for high-level client methods that are useful to you? I'd like to get an idea of what we could build |
|
Hi @quakelee, I appreciate your work here and sorry for this late response. |
|
This is opened for a long time. Please check the latest commit and let us know still need work for this. Thank you for your contribution. |
This is code change to make go-netbox support Netbox 2.6+ _choice api. The Value type is using json.RawMessage, user can unmarshal it with proper type when using corresponding choice.
In this request also include a small fix in netbox/client/dcim/dcim_interfaces_list_parameters.go
I changed the DeviceID type from float64 to int64, since DeviceID has no way to have a float64 value in Netbox, I don't know why it was generated as float.
and at last, I added more elements for ConnectedEndpoint struct to receive those values from API.
My app need them.