Skip to content
This repository was archived by the owner on Jul 5, 2021. It is now read-only.

Replace experimental flushEffects with act from react-dom/test-utils #71

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

jackdclark
Copy link
Contributor

We have been relying on an experimental flushEffects from react-testing-library to force effects to run when testing hooks. That has since been removed in favour of using act from react-dom/test-utils, as that also causes the effects to run. I've swapped all uses of flushEffects to use act instead.

Copy link

@lpww lpww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all passing

@lpww lpww merged commit 4101945 into master Feb 6, 2019
@lpww lpww deleted the remove-flush-effects branch February 6, 2019 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants