Update dev-containers to use CMake v3.31.6 #3145
Conversation
WalkthroughThe pull request updates multiple Dockerfiles within the development container configuration. Each container’s base image version has been incremented, and the corresponding source files now set the Changes
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (12)
🚧 Files skipped from review as they are similar to previous changes (12)
⏰ Context from checks skipped due to timeout of 90000ms (17)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
networkfusion
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.devcontainer/TI/Dockerfile.TI.SRC (1)
29-29: Typo in TI Tools Comment
There is a minor typo in the comment: “Cheack all versions here:” on line 29. Please update “Cheack” to “Check” to improve clarity..devcontainer/All/Dockerfile.All.SRC (1)
29-33: Minor Typo in TI Tools Comment
In the comment on line 29, "Cheack all versions here:" contains a typographical error. Please change “Cheack” to “Check” to maintain professionalism in documentation..github/workflows/devcontainer-smoketest.yaml (1)
22-22: Smoke Test Matrix Target Update & YAML Formatting
The smoke test matrix now includes the targetESP32_S2_USB—replacingFEATHER_S2—which aligns with the updated CI configuration. Additionally, YAMLlint flagged extra spaces after commas on this line; consider cleaning up the formatting for enhanced readability.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 22-22: too many spaces after comma
(commas)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
.devcontainer/All/Dockerfile.All(1 hunks).devcontainer/All/Dockerfile.All.SRC(1 hunks).devcontainer/AzureRTOS/Dockerfile.AzureRTOS(1 hunks).devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC(1 hunks).devcontainer/ChibiOS/Dockerfile.ChibiOS(1 hunks).devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC(1 hunks).devcontainer/ESP32/Dockerfile.ESP32(1 hunks).devcontainer/ESP32/Dockerfile.ESP32.SRC(1 hunks).devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP(1 hunks).devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC(1 hunks).devcontainer/TI/Dockerfile.TI(1 hunks).devcontainer/TI/Dockerfile.TI.SRC(1 hunks).github/workflows/devcontainer-smoketest.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/devcontainer-smoketest.yaml
[warning] 22-22: too many spaces after comma
(commas)
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: nf-interpreter (Nightly build) (Check_Build_Options)
- GitHub Check: nf-interpreter (Check_Build_Options)
- GitHub Check: build-target (TI_CC1352R1_LAUNCHXL, Debug, All, 915)
- GitHub Check: build-target (NXP_MIMXRT1060_EVK, Debug, All)
- GitHub Check: build-target (ESP32_H2_THREAD, Debug, ESP32)
- GitHub Check: build-target (ESP32_C6_THREAD, Debug, ESP32)
- GitHub Check: build-target (ESP32_C3, Debug, ESP32)
- GitHub Check: build-target (ESP32_S3, Debug, ESP32)
- GitHub Check: build-target (ESP32_S2_USB, Debug, ESP32)
- GitHub Check: build-target (ESP_WROVER_KIT, Debug, ESP32)
- GitHub Check: build-target (M5Core2, Debug, ESP32)
- GitHub Check: build-target (ST_STM32F769I_DISCOVERY, Debug, All)
- GitHub Check: build-target (ST_STM32F769I_DISCOVERY, Debug, ChibiOS)
- GitHub Check: build-target (SL_STK3701A, Debug, All)
- GitHub Check: build-target (SL_STK3701A, Debug, AzureRTOS)
🔇 Additional comments (14)
.devcontainer/All/Dockerfile.All (1)
1-2: Base Image Update Verification in All DockerfileThe
FROMline has been updated from versionv2.55tov2.56, which is consistent with the overall container upgrade strategy. Ensure that any dependencies or tooling that rely on the previous version are compatible with this change..devcontainer/TI/Dockerfile.TI (1)
1-2: TI Dockerfile Base Image UpdateThe Dockerfile successfully updates the base image from
v1.26tov1.27. Please verify that the corresponding update to the CMake version (from3.27.6to3.31.6) in the related.SRCDockerfile is in place, ensuring full alignment with the PR objectives..devcontainer/ChibiOS/Dockerfile.ChibiOS (1)
1-2: ChibiOS Dockerfile Base Image UpgradeThe updated base image version (
v1.34instead ofv1.33) appears correctly applied. As with other containers, confirm that the associated CMake version upgrade to3.31.6(likely in the.SRCcounterpart) remains consistent with the overall update..devcontainer/AzureRTOS/Dockerfile.AzureRTOS (1)
1-2: AzureRTOS Dockerfile Base Image and CMake Version AlignmentThe Dockerfile now uses the updated base image
v1.33(previouslyv1.32). Ensure that the upgrade of the CMake version to3.31.6is also reflected in the relevantDockerfile.AzureRTOS.SRCor any associated configuration files, as per the PR objectives..devcontainer/ESP32/Dockerfile.ESP32 (1)
1-2: ESP32 Dockerfile Update for Base Image and CMake VersionThe base image has been updated to
v2.36fromv2.35, which is in line with the coordinated container updates. Please double-check that the specified CMake version is updated to3.31.6in its corresponding.SRCDockerfile to maintain consistency..devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC (2)
20-27: Update CMake Version and Install Script
The change correctly updates the CMake version to 3.31.6 and adapts the download URL accordingly. The installation commands remain clear and functional.
29-29: Verify Base Image Version Consistency
The PR objectives mention an update of the base image version (from v1.32 to v1.33). Please confirm that the intended change is reflected in this Dockerfile (or if it should be applied elsewhere) since onlyFROM ubuntu:latest AS devcontaineris visible here..devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC (1)
20-27: Consistent Update of CMake Version
The Dockerfile clearly updatesARG CMAKE_VERSIONto 3.31.6 and regenerates the CMake script URL accordingly. The change is applied consistently in this file..devcontainer/TI/Dockerfile.TI.SRC (1)
20-27: Update of CMake Version
The TI Dockerfile now uses CMAKE_VERSION=3.31.6 and the associated URL is updated for the CMake installation. This change is correct and uniform with the other Dockerfiles..devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC (2)
20-27: CMake Version Updated Consistently
The update to ARG CMAKE_VERSION=3.31.6 and its use in constructing the download URL is applied correctly in this Dockerfile.
29-29: Verify Base Image Update for Devcontainer
The PR summary indicates an update of the base image (from v1.05 to v1.06) for the FreeRTOS-NXP container. However, the devcontainer stage is defined asFROM python:3.10 AS devcontainer. Please confirm that the intended base image update is correctly reflected here..devcontainer/All/Dockerfile.All.SRC (1)
20-27: Updated CMake Version
The Dockerfile has been updated to set ARG CMAKE_VERSION=3.31.6; the corresponding CMake script URL now reflects the new version. This update is consistent with the other container configurations..devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP (1)
1-1: Base Image Update Verified
The Dockerfile now uses the updated base imagev1.06, which is consistent with the broader update across development containers..devcontainer/ESP32/Dockerfile.ESP32.SRC (1)
12-20: Updated CMake Version Argument
The ARG directive forCMAKE_VERSIONhas been updated to3.31.6, and the download script URL correctly incorporates this version. This update is in line with the objective to use the latest CMake version across dev containers. Please verify that all downstream scripts and installations are compatible with this version.
josesimoes
changed the title
josesimoes
force-pushed
the
networkfusion/dev-containers-src-cmake
branch
from
ffa6f9f to
6025132
Compare
josesimoes
changed the title
Description
Motivation and Context
This is the latest cmake version compatible and will be used by the CI.
How Has This Been Tested?
Screenshots
Types of changes
Checklist
Summary by CodeRabbit
These enhancements help streamline container builds and contribute to a more robust and efficient development environment.