-
-
Notifications
You must be signed in to change notification settings - Fork 179
Improve devcontainer file structure #2854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve devcontainer file structure #2854
Conversation
@alberk8 Given I know that you use devcontainers, if you can also test this and add feedback, it would be welcome. |
@networkfusion, It works but rather annoying is that you need to select the Dev Container every time you reopen the container. Is it possible to have something like selecting the target where it will resists across Container restart?. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hat will definitely be much cleaner! And I think the action should be adjusted, see my comment
acbff0e
to
fea81cc
Compare
Adjust GH workflow.
Improve push action
Comment back out smoketests
@Ellerbach any response to the comments before merge? |
go ahead, nothing we can't correct later anyway ;-) |
Description
Superseeds (part implementation of) Switch dev containers to seperate directories #2816
Motivation and Context
Although there are some futher changes I would like to make (in another PR), this moves the devcontainers to seperate directories which makes it easier for users to choose and develop against their respective platforms in a devcontainer.
It fixes the various issues raised against the last PR.
How Has This Been Tested?
Screenshots
Types of changes
Checklist