-
-
Notifications
You must be signed in to change notification settings - Fork 180
Support for generics #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support for generics #1802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated fixes for code style.
Automated fixes for code style.
Automated fixes for code style.
Automated fixes for code style.
Automated fixes for code style.
Automated fixes for code style.
@sake402 I'm merging this into it's own branch so it can be worked from there. |
josesimoes
added a commit
to Eclo/nf-interpreter
that referenced
this pull request
Mar 6, 2023
***NO_CI***
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides initial support for generic types
Description
Generic class and method generic parameters are looked up from the heapblock at runtime
Motivation and Context
This is meant to open opportunities to advance C# techniques, especially async
How Has This Been Tested?
Sample tests are in Test Application
What is working
Creating and constructing a generic class
Calling a generic method, instance or static
Passing generic parameter (reference type, value type or ref)
Not working yet
Returning a generic type from a method because the CLR_RECORD_METHODDEF::retVal was set by the MDP to be void and result is therefore not pushed onto the calling stack when returning, corrupting the calling stack in the process. Will need to update the MDP to effect this
Types of changes
Checklist: