[DataGrid] Fix theme defaultProps causing unwanted re-renders
#17490
+21
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
KenanYusuf
added
performance
component: data grid
KenanYusuf
changed the title
KenanYusuf
changed the title
defaultProps causing unwanted re-renders
|
Deploy preview: https://deploy-preview-17490--material-ui-x.netlify.app/ |
KenanYusuf
commented
Apr 22, 2025
| @@ -64,12 +65,11 @@ export const DATA_GRID_PREMIUM_PROPS_DEFAULT_VALUES: DataGridPremiumPropsWithDef | |||
| const defaultSlots = DATA_GRID_PREMIUM_DEFAULT_SLOTS_COMPONENTS; | |||
|
|
|||
| export const useDataGridPremiumProps = (inProps: DataGridPremiumProps) => { | |||
| const themedProps = | |||
| // eslint-disable-next-line material-ui/mui-name-matches-component-name | |||
| useThemeProps({ | |||
There was a problem hiding this comment.
The returned value from useThemeProps is not memoized. See mui/material-ui#45943
romgrk
approved these changes
Apr 22, 2025
arminmeh
approved these changes
Apr 23, 2025
KenanYusuf
added
needs cherry-pick
MBilalShafi
approved these changes
Apr 23, 2025
|
Cherry-pick PRs will be created targeting branches: v7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixes #17128 using an alternate approach to mui/material-ui#45943
Before
All cells change value when entering edit mode.
https://codesandbox.io/p/sandbox/17490-before-76t4mt
before.mov
After
Only the selected cell changes value when entering edit mode.
https://codesandbox.io/p/sandbox/17490-after-ftlktq
after.mov