-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[charts-pro] Zoom pointer improvements #17480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JCQuintas
wants to merge
85
commits into
mui:master
Choose a base branch
from
JCQuintas:pointer-events-manual
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+796
−597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…events-improvement
…events-improvement
Thanks for adding a type label to the PR! 👍 |
Deploy preview: https://deploy-preview-17480--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #17480 will not alter performanceComparing Summary
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: charts
This is the name of the generic UI component, not the React module!
enhancement
This is not a bug, nor a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16205
Fixes #16549
Fixes #16660
Supersedes #17000
Difference from the other PR
This uses
@web-gestures/core
to recognise the gestures. I've made the lib from scratch, thinking about extensibility and using the native event emitter api.It should be much lighter and extensible than anything else, though it is new. So bugs might be preset 😆
As I mentioned in one of our previous meeting. It would be nice to have it as part of MUI offering if we deem it a good to have. For now it stays as a separate project.
Main change (same as last PR)
Create a
interaction listener
plugin. This allows us to register events directly in the SVG.The current implementation migrates most of the interactions to the schema below.
Other changes
usePanOnDrag
,useZoomOnPinch
anduseZoomOnWheel
hooks