Skip to content

[data grid][docs] Fix Localization page title #17475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 21, 2025

Match with the sidenav:

SCR-20250421-nbpu

No reasons for the two to be different.

Also, closer to the baseline model we aim to copy in X: https://mui.com/material-ui/guides/localization/


Off-topic. On the localization topic, more generally, https://mui.com/x/react-date-pickers/localization/ went in a different direction, we will likely need to cherry-pick the best of the two worlds to unify the approach so it's simple to follow for users. https://mui-org.slack.com/archives/C074TBYQK2T/p1745238404469119 is a great signal that the docs structure for localization can be fixed.

But at least, in the case of the pickers, the page was split in different sub-pages, so on that very topic that this PR touches on, it also fit well in the global story.

A proposal:

  • localeTextConstants.ts -> enUS.ts. Pickers seem better
  • Add English (United States) / en-US in the list of supported locales
  • Have this structure:
# Localization

> Localization (also referred to as "l10n") is the process of adapting a product or content to a specific locale or market.

The default locale is English (United States). If you want to use other locales, follow the instructions below.

## Localize text

### Translation keys

### Set translations locally

### Set translations globally

### Example

-### Supported locales
+### Built-in locales

<!--
Supported locales is confusing, it implies that what's not in there is not supported.
No, it's only not included in the default build.
-->

-## RTL Support
+## Right-to-left support

<!-- Consistent header -->

## Localize date format

## UTC and timezones (if relevant)

## Calendar systems (if relevant)

and break it in different pages if it's too heavy for one.

Copy link

github-actions bot commented Apr 21, 2025

Thanks for adding a type label to the PR! 👍

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Apr 21, 2025
@mui-bot
Copy link

mui-bot commented Apr 21, 2025

@oliviertassinari oliviertassinari added the l10n localization label Apr 21, 2025
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work and removed enhancement This is not a bug, nor a new feature labels Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants