-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[core] Proof of concept for solving the .d.ts generation issue #24132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7fa3468
to
62276e8
Compare
62276e8
to
919a160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me take a look at that. This is only fixing symptoms but not the underlying issue.
@eps1lon Anything we can help with? |
@eps1lon Agree, let's hold on for some time. I have tried to find the root issue but gave up after an hour. If we can figure it out, that would be better, in case we hit the problem in another case in the future. If we don't, I think that we could live without it too. The proposed approach 1. wrecks the types with @HofmannZ During the end of year holidays, things might move slowly. Feel free to spend time exploring what's wrong. The closest I could find was microsoft/TypeScript#24599 which was relative to a fs case sensibility issue in the core of TypeScript. |
My intuition tells me we need a change at the tsconfig/ Alternatively we get a smoke test for the build output (started in #23166) that catches these regressions. Either way I want to make sure this doesn't get lost over the holidays since it's important to get right before v5. I rather block it in this instance to keep visibility up instead of merging a quick fix that'll just re-surface later. |
The generated declaration from
It makes sense because it's pretty hard to generate a sensible type in this particular instance but |
One part of #24112.