test: suggested updates for testing if typecheck middleware is installed #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrloop Thanks for your patience on typed-ember#1148! We'd love to get that change in before our first 4.0 release candidate
I'm opening this PR to suggest a slightly different approach to testing whether the typecheck middleware is installed or not. You seemed to be having to jump through a lot of hoops to work around the fact that
ember test
in the skeleton app would never actually terminate, so this PR fixes the skeleton app's fixtures so that the tests will actually run to completion.In addition to that change, I also updated the addon to emit debug messages indicating whether the typecheck middleware is being included or not so we have something easier to assert against.
I think those two changes together avoid a lot of the gymnastics we were forcing on you to test your change, so hopefully this is an improvement 🙂