Skip to content

test: suggested updates for testing if typecheck middleware is installed #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dfreeman
Copy link

@dfreeman dfreeman commented Jul 3, 2020

@mrloop Thanks for your patience on typed-ember#1148! We'd love to get that change in before our first 4.0 release candidate

I'm opening this PR to suggest a slightly different approach to testing whether the typecheck middleware is installed or not. You seemed to be having to jump through a lot of hoops to work around the fact that ember test in the skeleton app would never actually terminate, so this PR fixes the skeleton app's fixtures so that the tests will actually run to completion.

In addition to that change, I also updated the addon to emit debug messages indicating whether the typecheck middleware is being included or not so we have something easier to assert against.

I think those two changes together avoid a lot of the gymnastics we were forcing on you to test your change, so hopefully this is an improvement 🙂

@mrloop
Copy link
Owner

mrloop commented Jul 3, 2020

@dfreeman thanks! Especially like adding the extra debug messages, makes things explicit and simpler.

@mrloop mrloop merged commit 7decf1b into mrloop:middleware-options Jul 3, 2020
@dfreeman dfreeman deleted the middleware-options-fork branch July 3, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants