RUST-1122 Fix x509 auth for pkcs8 keys and Atlas free tier #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
reviewed
Dec 2, 2021
abr-egn
commented
Dec 3, 2021
src/coll/mod.rs
Outdated
| @@ -1140,6 +1140,7 @@ where | |||
| let docs: Vec<&T> = ds.iter().skip(n_attempted).map(Borrow::borrow).collect(); | |||
| let insert = Insert::new(self.namespace(), docs, options.clone()); | |||
|
|
|||
| #[allow(clippy::needless_option_as_deref)] | |||
There was a problem hiding this comment.
This appears to be a clippy false-positive; the suggestion (just session) doesn't work because this is in a loop, which I think is context clippy isn't looking at.
There was a problem hiding this comment.
Yep, see rust-lang/rust-clippy#8047. I actually already pushed a fix for these errors last night, so you can omit these changes from here.
There was a problem hiding this comment.
Ah, thanks; removed.
abr-egn
force-pushed
the
RUST-1122/x509-auth
branch
from
49f3f12 to
4dd6fc7
Compare
|
Hype |
isabelatkinson
approved these changes
Dec 9, 2021
abr-egn
added a commit
that referenced
this pull request
Dec 13, 2021
abr-egn
added a commit
to abr-egn/mongo-rust-driver
that referenced
this pull request
Dec 13, 2021
abr-egn
added a commit
to abr-egn/mongo-rust-driver
that referenced
this pull request
Dec 14, 2021
abr-egn
added a commit
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.