Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and document Java sync improved bulk write API #1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and document Java sync improved bulk write API #1458
Changes from 34 commits
48b9614
af854ed
1eb7466
5567324
644d561
f566303
3d13ffd
cf46b46
e049234
0e16427
0d518d8
6b77f78
fdb90d2
39386fe
f67af3f
395af7a
a11e5f6
f41ed59
4846e0b
dbf9a26
21bb22e
f026ee3
3584de5
5a17ea0
8e1d770
e973615
e33f592
301a2ba
6f01e61
c3224e9
c057390
dbb6ec8
f781bca
3fc86bb
86e5234
fb134f8
a4bf4d0
2837235
b6702a6
24ce6db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While
Verbose
accurately suggests that it provides more detailed or extended information than plain result, using an adjective as a class or interface name is somewhat unconventional in Java spec and the name might not immediately convey its purpose.I would suggest noun-based naming, just couple of examples:
VerboseBulkResult
/ExtendedBulkResult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent was to refer to it as
ClientBulkWriteResult.Verbose
. I updated the code where this was not done, and following is how the rendered API docs look likeDo you still think this type should be renamed? If yes, then
VerboseResults
is the name I'll use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in b6702a6.