test: bson corpus spec runner calling wrong fn #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
requested review from
a team,
emadum,
nbbeeken and
dariakp
and removed request for
a team
durran
force-pushed
the
fix-corpus-spec-runner
branch
from
ede54d2 to
69150d6
Compare
|
@durran Looks good but I think per our convention, the commit message should be |
durran
changed the title
durran
force-pushed
the
fix-corpus-spec-runner
branch
from
69150d6 to
8b85a70
Compare
emadum
suggested changes
May 14, 2021
nbbeeken
approved these changes
May 24, 2021
emadum
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this one-liner when looking into
Decimal128usages. (Of course they all were passing sinceDecimal.128.fromStringwould never be able to deserialize the EJSON, so we now use the EJSON parse helper function, which passes, but aren't false positives)NODE-3277